lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 108/530] Revert "drm/qxl: do not run release if qxl failed to init"
    Date
    From: Gerd Hoffmann <kraxel@redhat.com>

    commit 93d8da8d7efbf690c0a9eaca798acc0c625245e6 upstream.

    This reverts commit b91907a6241193465ca92e357adf16822242296d.

    Patch is broken, it effectively makes qxl_drm_release() a nop
    because on normal driver shutdown qxl_drm_release() is called
    *after* drm_dev_unregister().

    Fixes: b91907a62411 ("drm/qxl: do not run release if qxl failed to init")
    Cc: Tong Zhang <ztong0001@gmail.com>
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
    Link: http://patchwork.freedesktop.org/patch/msgid/20210204145712.1531203-3-kraxel@redhat.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/qxl/qxl_drv.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/gpu/drm/qxl/qxl_drv.c
    +++ b/drivers/gpu/drm/qxl/qxl_drv.c
    @@ -144,8 +144,6 @@ static void qxl_drm_release(struct drm_d
    * reodering qxl_modeset_fini() + qxl_device_fini() calls is
    * non-trivial though.
    */
    - if (!dev->registered)
    - return;
    qxl_modeset_fini(qdev);
    qxl_device_fini(qdev);
    }

    \
     
     \ /
      Last update: 2021-05-12 18:02    [W:15.804 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site