lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 188/530] soundwire: bus: Fix device found flag correctly
    Date
    From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

    [ Upstream commit f03690f4f6992225d05dbd1171212e5be5a370dd ]

    found flag is used to indicate SoundWire devices that are
    both enumerated on the bus and available in the device list.
    However this flag is not reset correctly after one iteration,
    This could miss some of the devices that are enumerated on the
    bus but not in device list. So reset this correctly to fix this issue!

    Fixes: d52d7a1be02c ("soundwire: Add Slave status handling helpers")
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Link: https://lore.kernel.org/r/20210309104816.20350-1-srinivas.kandagatla@linaro.org
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soundwire/bus.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
    index 1fe786855095..3317a02bcc17 100644
    --- a/drivers/soundwire/bus.c
    +++ b/drivers/soundwire/bus.c
    @@ -703,7 +703,7 @@ static int sdw_program_device_num(struct sdw_bus *bus)
    struct sdw_slave *slave, *_s;
    struct sdw_slave_id id;
    struct sdw_msg msg;
    - bool found = false;
    + bool found;
    int count = 0, ret;
    u64 addr;

    @@ -735,6 +735,7 @@ static int sdw_program_device_num(struct sdw_bus *bus)

    sdw_extract_slave_id(bus, addr, &id);

    + found = false;
    /* Now compare with entries */
    list_for_each_entry_safe(slave, _s, &bus->slaves, node) {
    if (sdw_compare_devid(slave, id) == 0) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 18:02    [W:4.145 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site