lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 224/244] powerpc/52xx: Fix an invalid ASM expression (addi used instead of add)
    Date
    From: Christophe Leroy <christophe.leroy@csgroup.eu>

    [ Upstream commit 8a87a507714386efc39c3ae6fa24d4f79846b522 ]

    AS arch/powerpc/platforms/52xx/lite5200_sleep.o
    arch/powerpc/platforms/52xx/lite5200_sleep.S: Assembler messages:
    arch/powerpc/platforms/52xx/lite5200_sleep.S:184: Warning: invalid register expression

    In the following code, 'addi' is wrong, has to be 'add'

    /* local udelay in sram is needed */
    udelay: /* r11 - tb_ticks_per_usec, r12 - usecs, overwrites r13 */
    mullw r12, r12, r11
    mftb r13 /* start */
    addi r12, r13, r12 /* end */

    Fixes: ee983079ce04 ("[POWERPC] MPC5200 low power mode")
    Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/cb4cec9131c8577803367f1699209a7e104cec2a.1619025821.git.christophe.leroy@csgroup.eu
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/52xx/lite5200_sleep.S | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/platforms/52xx/lite5200_sleep.S b/arch/powerpc/platforms/52xx/lite5200_sleep.S
    index 3a9969c429b3..054f927bfef9 100644
    --- a/arch/powerpc/platforms/52xx/lite5200_sleep.S
    +++ b/arch/powerpc/platforms/52xx/lite5200_sleep.S
    @@ -181,7 +181,7 @@ sram_code:
    udelay: /* r11 - tb_ticks_per_usec, r12 - usecs, overwrites r13 */
    mullw r12, r12, r11
    mftb r13 /* start */
    - addi r12, r13, r12 /* end */
    + add r12, r13, r12 /* end */
    1:
    mftb r13 /* current */
    cmp cr0, r13, r12
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 17:31    [W:2.403 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site