Messages in this thread | | | Subject | Re: [PATCH 4/4] extcon: extcon-max8997: Fix IRQ freeing at error path | From | Krzysztof Kozlowski <> | Date | Tue, 11 May 2021 12:27:10 -0400 |
| |
On 10/05/2021 23:32, Matti Vaittinen wrote: > Hi Krzysztof, > > On Mon, 2021-05-10 at 10:21 -0400, Krzysztof Kozlowski wrote: >> On 10/05/2021 04:12, Matti Vaittinen wrote: >>> If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits >>> without freeing the requested IRQs. >> >> The driver frees IRQ on probe failure, so maybe you meant missing IRQ >> mapping dispose? > > No. The commit 3e34c8198960 ("extcon: max8997: Avoid forcing UART path > on drive probe") introduced a return w/o IRQ freeing if reading the > MAX8997_MUIC_REG_STATUS1 fails at the end of the probe. This is not > visible in the patch though - as the return is Ok after the IRQs and > work-queue cancellation are managed by devm.
I see it now, right. The fix is big and changes too much to be backportable. I would prefer to simply fix the problem with "goto err_irq" and convert to devm in next patch.
Best regards, Krzysztof
| |