Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v2 6/8] sched/idle: Move busy_cpu accounting to idle callback | Date | Tue, 11 May 2021 12:51:41 +0100 |
| |
On 06/05/21 22:15, Srikar Dronamraju wrote: > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 8db40c8a6ad0..00e4669bb241 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -647,6 +647,7 @@ DEFINE_PER_CPU(int, sd_llc_id); > #ifdef CONFIG_SCHED_SMT > DEFINE_PER_CPU(int, smt_id); > #endif > +DEFINE_PER_CPU(int, is_idle);
This + patch 8 immediately reminds me of Aubrey's patch:
http://lore.kernel.org/r/1615872606-56087-1-git-send-email-aubrey.li@intel.com
last I looked it seemed OK, even the test bot seems happy. Aubrey, did you have any more work to do on that one (other than rebasing)?
> DEFINE_PER_CPU(struct sched_domain_shared __rcu *, sd_llc_shared); > DEFINE_PER_CPU(struct sched_domain __rcu *, sd_numa); > DEFINE_PER_CPU(struct sched_domain __rcu *, sd_asym_packing); > @@ -673,6 +674,7 @@ static void update_top_cache_domain(int cpu) > #ifdef CONFIG_SCHED_SMT > per_cpu(smt_id, cpu) = cpumask_first(cpu_smt_mask(cpu)); > #endif > + per_cpu(is_idle, cpu) = 1; > rcu_assign_pointer(per_cpu(sd_llc_shared, cpu), sds); > > sd = lowest_flag_domain(cpu, SD_NUMA); > -- > 2.18.2
| |