Messages in this thread | | | Date | Tue, 11 May 2021 10:07:10 +0200 | From | Oscar Salvador <> | Subject | Re: [External] Re: [PATCH v23 6/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page |
| |
On Mon, May 10, 2021 at 08:19:47PM +0800, Muchun Song wrote: > Not exactly right. free_huge_page() does not clear HPageTemporary > if the page is temporarily allocated when freeing. You are right that > dissolve_free_huge_page() does not clear HPageFreed.
Right, I missed that.
> Because I think it is the reverse operation of remove_hugetlb_page, > I named it add_hugetlb_page. Do you have any suggestions for > renaming?
Ok, if it is the counter part, the name makes sense. I would have appreciated a comment explaining e.g: under which circumtances is being called, etc. but not a blocker, can be done on top.
Reviewed-by: Oscar Salvador <osalvador@suse.de>
-- Oscar Salvador SUSE L3
| |