Messages in this thread | | | Date | Tue, 11 May 2021 10:28:50 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 11/12] tools: sync lib/find_bit implementation |
| |
On Tue, May 11, 2021 at 12:51:58AM +0200, Rikard Falkeborn wrote: > On Mon, May 10, 2021 at 06:44:44PM +0300, Andy Shevchenko wrote:
...
> Does the following work for you? For simplicity, I copied__is_constexpr from > include/linux/minmax.h (which isn't available in tools/). A proper patch > would reuse __is_constexpr (possibly refactoring it to a separate > header since bits.h including minmax.h for that only seems smelly)
I think we need to have it in something like compiler.h (top level). Under 'top level' I meant something with the function as of compiler.h but with Linuxisms rather than compiler attributes or so.
Separate header for the (single) macro is too much...
> and fix > bits.h in the kernel header as well, to keep the files in sync.
Right.
-- With Best Regards, Andy Shevchenko
| |