lkml.org 
[lkml]   [2021]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 186/342] selftests/resctrl: Fix compilation issues for other global variables
    Date
    From: Fenghua Yu <fenghua.yu@intel.com>

    [ Upstream commit 896016d2ad051811ff9c9c087393adc063322fbc ]

    Reinette reported following compilation issue on Fedora 32, gcc version
    10.1.1

    /usr/bin/ld: resctrl_tests.o:<src_dir>/resctrl.h:65: multiple definition
    of `bm_pid'; cache.o:<src_dir>/resctrl.h:65: first defined here

    Other variables are ppid, tests_run, llc_occup_path, is_amd. Compiler
    isn't happy because these variables are defined globally in two .c files
    but are not declared as extern.

    To fix issues for the global variables, declare them as extern.

    Chang Log:
    - Split this patch from v4's patch 1 (Shuah).

    Reported-by: Reinette Chatre <reinette.chatre@intel.com>
    Tested-by: Babu Moger <babu.moger@amd.com>
    Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/resctrl/resctrl.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
    index 959c71e39bdc..12b77182cb44 100644
    --- a/tools/testing/selftests/resctrl/resctrl.h
    +++ b/tools/testing/selftests/resctrl/resctrl.h
    @@ -62,11 +62,11 @@ struct resctrl_val_param {
    int (*setup)(int num, ...);
    };

    -pid_t bm_pid, ppid;
    -int tests_run;
    +extern pid_t bm_pid, ppid;
    +extern int tests_run;

    -char llc_occup_path[1024];
    -bool is_amd;
    +extern char llc_occup_path[1024];
    +extern bool is_amd;

    bool check_resctrlfs_support(void);
    int filter_dmesg(void);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-10 13:41    [W:3.776 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site