lkml.org 
[lkml]   [2021]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 103/299] crypto: sun8i-ce - Fix PM reference leak in sun8i_ce_probe()
    Date
    From: Shixin Liu <liushixin2@huawei.com>

    [ Upstream commit cc987ae9150c255352660d235ab27c834aa527be ]

    pm_runtime_get_sync will increment pm usage counter even it failed.
    Forgetting to putting operation will result in reference leak here.
    Fix it by replacing it with pm_runtime_resume_and_get to keep usage
    counter balanced.

    Signed-off-by: Shixin Liu <liushixin2@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
    index 158422ff5695..00194d1d9ae6 100644
    --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
    +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
    @@ -932,7 +932,7 @@ static int sun8i_ce_probe(struct platform_device *pdev)
    if (err)
    goto error_alg;

    - err = pm_runtime_get_sync(ce->dev);
    + err = pm_runtime_resume_and_get(ce->dev);
    if (err < 0)
    goto error_alg;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-10 13:31    [W:4.134 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site