lkml.org 
[lkml]   [2021]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 005/299] dyndbg: fix parsing file query without a line-range suffix
    Date
    From: Shuo Chen <shuochen@google.com>

    commit 7b1ae248279bea33af9e797a93c35f49601cb8a0 upstream.

    Query like 'file tcp_input.c line 1234 +p' was broken by
    commit aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file
    foo.c:10-100'") because a file name without a ':' now makes the loop in
    ddebug_parse_query() exits early before parsing the 'line 1234' part.
    As a result, all pr_debug() in tcp_input.c will be enabled, instead of only
    the one on line 1234. Changing 'break' to 'continue' fixes this.

    Fixes: aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'")
    Cc: stable <stable@vger.kernel.org>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Shuo Chen <shuochen@google.com>
    Acked-by: Jason Baron <jbaron@akamai.com>
    Link: https://lore.kernel.org/r/20210414212400.2927281-1-giantchen@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    lib/dynamic_debug.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -396,7 +396,7 @@ static int ddebug_parse_query(char *word
    /* tail :$info is function or line-range */
    fline = strchr(query->filename, ':');
    if (!fline)
    - break;
    + continue;
    *fline++ = '\0';
    if (isalpha(*fline) || *fline == '*' || *fline == '?') {
    /* take as function name */

    \
     
     \ /
      Last update: 2021-05-10 13:31    [W:4.065 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site