Messages in this thread | | | Date | Mon, 10 May 2021 17:21:33 -0700 | From | Jaegeuk Kim <> | Subject | Re: [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask |
| |
On 05/10, Eric Biggers wrote: > On Mon, May 10, 2021 at 07:42:27AM -0700, Jaegeuk Kim wrote: > > In f2fs_fileattr_set(), > > > > if (!fa->flags_valid) > > mask &= FS_COMMON_FL; > > > > In this case, we can set supported flags by mask only instead of BUG_ON. > > > > /* Flags shared betwen flags/xflags */ > > (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ > > FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \ > > FS_PROJINHERIT_FL) > > > > Fixes: 4c5b47997521 ("vfs: add fileattr ops") > > Shouldn't it be: > > Fixes: 9b1bb01c8ae7 ("f2fs: convert to fileattr")
Heh, thank you. I applied this change in the git. :)
| |