Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] sh: remove unused variable | Date | Mon, 10 May 2021 22:56:21 +0200 |
| |
On Mon, May 10 2021 at 22:11, Eric Dumazet wrote: > On 4/14/21 7:05 PM, Eric Dumazet wrote: >> From: Eric Dumazet <edumazet@google.com> >> >> Removes this annoying warning: >> >> arch/sh/kernel/traps.c: In function ‘nmi_trap_handler’: >> arch/sh/kernel/traps.c:183:15: warning: unused variable ‘cpu’ [-Wunused-variable] >> 183 | unsigned int cpu = smp_processor_id(); >> >> Fixes: fe3f1d5d7cd3 ("sh: Get rid of nmi_count()") >> Signed-off-by: Eric Dumazet <edumazet@google.com> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Frederic Weisbecker <frederic@kernel.org> >> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> >> Cc: Rich Felker <dalias@libc.org> >> --- >> arch/sh/kernel/traps.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/sh/kernel/traps.c b/arch/sh/kernel/traps.c >> index f5beecdac69382f2d719fa33d50b9d58e22f6ff8..e76b221570999776e3bc9276d6b2fd60b9132e94 100644 >> --- a/arch/sh/kernel/traps.c >> +++ b/arch/sh/kernel/traps.c >> @@ -180,7 +180,6 @@ static inline void arch_ftrace_nmi_exit(void) { } >> >> BUILD_TRAP_HANDLER(nmi) >> { >> - unsigned int cpu = smp_processor_id(); >> TRAP_HANDLER_DECL; >> >> arch_ftrace_nmi_enter(); >> > > Is there anything wrong with this patch ?
No. I was expecting that it gets picked up by sh folks. Let me take care of it as I introduced that issue after all.
Thanks,
tglx
| |