Messages in this thread | | | From | Stephen Boyd <> | Date | Mon, 10 May 2021 09:55:09 -0700 | Subject | Re: [PATCH v2 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() |
| |
Quoting Zhen Lei (2021-05-09 23:38:05) > The error code returned by platform_get_irq() is stored in 'irq', it's > forgotten to be copied to 'ret' before being returned. As a result, the > value 0 of 'ret' is returned incorrectly. > > After the above fix is completed, initializing the local variable 'ret' > to 0 is no longer needed, remove it. > > In addition, when dpu_mdss_init() is successfully returned, the value of > 'ret' is always 0. Therefore, replace "return ret" with "return 0" to make > the code clearer. > > Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| |