Messages in this thread | | | Date | Mon, 10 May 2021 08:51:04 -0700 | From | Jaegeuk Kim <> | Subject | Re: [PATCH 1/3] f2fs: compress: fix to call f2fs_put_dnode() paired with f2fs_get_block() |
| |
On 05/10, Chao Yu wrote: > f2fs_get_block() and f2fs_put_dnode() should be called as a pair, > add missing f2fs_put_dnode() in prepare_compress_overwrite(). > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Signed-off-by: Chao Yu <yuchao0@huawei.com> > --- > fs/f2fs/compress.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > index c208563eac28..d5cb0ba9a0e1 100644 > --- a/fs/f2fs/compress.c > +++ b/fs/f2fs/compress.c > @@ -1088,6 +1088,7 @@ static int prepare_compress_overwrite(struct compress_ctx *cc, > > for (i = cc->cluster_size - 1; i > 0; i--) { > ret = f2fs_get_block(&dn, start_idx + i); > + f2fs_put_dnode(&dn);
f2fs_reserve_block() -> need_put = true; -> f2fs_put_dnode();
> if (ret) { > i = cc->cluster_size; > break; > -- > 2.29.2
| |