lkml.org 
[lkml]   [2021]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 018/384] ftrace: Handle commands when closing set_ftrace_filter file
    Date
    From: Steven Rostedt (VMware) <rostedt@goodmis.org>

    commit 8c9af478c06bb1ab1422f90d8ecbc53defd44bc3 upstream.

    # echo switch_mm:traceoff > /sys/kernel/tracing/set_ftrace_filter

    will cause switch_mm to stop tracing by the traceoff command.

    # echo -n switch_mm:traceoff > /sys/kernel/tracing/set_ftrace_filter

    does nothing.

    The reason is that the parsing in the write function only processes
    commands if it finished parsing (there is white space written after the
    command). That's to handle:

    write(fd, "switch_mm:", 10);
    write(fd, "traceoff", 8);

    cases, where the command is broken over multiple writes.

    The problem is if the file descriptor is closed, then the write call is
    not processed, and the command needs to be processed in the release code.
    The release code can handle matching of functions, but does not handle
    commands.

    Cc: stable@vger.kernel.org
    Fixes: eda1e32855656 ("tracing: handle broken names in ftrace filter")
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/trace/ftrace.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/kernel/trace/ftrace.c
    +++ b/kernel/trace/ftrace.c
    @@ -5631,7 +5631,10 @@ int ftrace_regex_release(struct inode *i

    parser = &iter->parser;
    if (trace_parser_loaded(parser)) {
    - ftrace_match_records(iter->hash, parser->buffer, parser->idx);
    + int enable = !(iter->flags & FTRACE_ITER_NOTRACE);
    +
    + ftrace_process_regex(iter, parser->buffer,
    + parser->idx, enable);
    }

    trace_parser_put(parser);

    \
     
     \ /
      Last update: 2021-05-10 15:02    [W:3.270 / U:3.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site