Messages in this thread Patch in this message | | | Subject | Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry | From | "Bernard Metzler" <> | Date | Mon, 10 May 2021 08:25:27 +0000 |
| |
-----"Leon Romanovsky" <leon@kernel.org> wrote: -----
>To: "Doug Ledford" <dledford@redhat.com>, "Jason Gunthorpe" ><jgg@nvidia.com> >From: "Leon Romanovsky" <leon@kernel.org> >Date: 05/09/2021 01:41PM >Cc: "Leon Romanovsky" <leonro@nvidia.com>, "Bernard Metzler" ><bmt@zurich.ibm.com>, linux-kernel@vger.kernel.org, >linux-rdma@vger.kernel.org >Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Release xarray entry > >From: Leon Romanovsky <leonro@nvidia.com> > >The xarray entry is allocated in siw_qp_add(), but release was >missed in case zero-sized SQ was discovered. > >Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and >Receive Queues.") >Signed-off-by: Leon Romanovsky <leonro@nvidia.com> >--- > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/infiniband/sw/siw/siw_verbs.c >b/drivers/infiniband/sw/siw/siw_verbs.c >index 917c8a919f38..3f175f220a22 100644 >--- a/drivers/infiniband/sw/siw/siw_verbs.c >+++ b/drivers/infiniband/sw/siw/siw_verbs.c >@@ -375,7 +375,7 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd, > else { > /* Zero sized SQ is not supported */ > rv = -EINVAL; >- goto err_out; >+ goto err_out_xa; > } > if (num_rqe) > num_rqe = roundup_pow_of_two(num_rqe); >-- >2.31.1 > > Thanks Leon!
Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
| |