lkml.org 
[lkml]   [2021]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 223/299] Makefile: Move -Wno-unused-but-set-variable out of GCC only block
    Date
    From: Nathan Chancellor <nathan@kernel.org>

    commit 885480b084696331bea61a4f7eba10652999a9c1 upstream.

    Currently, -Wunused-but-set-variable is only supported by GCC so it is
    disabled unconditionally in a GCC only block (it is enabled with W=1).
    clang currently has its implementation for this warning in review so
    preemptively move this statement out of the GCC only block and wrap it
    with cc-disable-warning so that both compilers function the same.

    Cc: stable@vger.kernel.org
    Link: https://reviews.llvm.org/D100581
    Signed-off-by: Nathan Chancellor <nathan@kernel.org>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Tested-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    Makefile | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/Makefile
    +++ b/Makefile
    @@ -775,16 +775,16 @@ KBUILD_CFLAGS += -Wno-gnu
    KBUILD_CFLAGS += -mno-global-merge
    else

    -# These warnings generated too much noise in a regular build.
    -# Use make W=1 to enable them (see scripts/Makefile.extrawarn)
    -KBUILD_CFLAGS += -Wno-unused-but-set-variable
    -
    # Warn about unmarked fall-throughs in switch statement.
    # Disabled for clang while comment to attribute conversion happens and
    # https://github.com/ClangBuiltLinux/linux/issues/636 is discussed.
    KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough,)
    endif

    +# These warnings generated too much noise in a regular build.
    +# Use make W=1 to enable them (see scripts/Makefile.extrawarn)
    +KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
    +
    KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
    ifdef CONFIG_FRAME_POINTER
    KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls

    \
     
     \ /
      Last update: 2021-05-10 14:02    [W:4.115 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site