Messages in this thread | | | Date | Fri, 9 Apr 2021 14:27:34 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag |
| |
On Wed, Apr 07, 2021 at 07:33:57AM +0200, Uwe Kleine-König wrote: > On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote: > > Add the flag and corresponding documentation for the new PWM staggering > > mode feature. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com> > > For the record, I don't like this and still prefer to make this > staggering explicit for the consumer by expanding struct pwm_state with > an .offset member to shift the active phase in the period.
How are consumers supposed to know which offset to choose? And worse: how should consumers even know that the driver supports phase shifts?
Thierry [unhandled content-type:application/pgp-signature] | |