Messages in this thread | | | From | David Howells <> | Subject | Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions | Date | Fri, 09 Apr 2021 13:00:40 +0100 |
| |
Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, Apr 09, 2021 at 11:59:17AM +0100, David Howells wrote: > > Make functions that test page bits return a bool, not an int. This means > > that the value is definitely 0 or 1 if they're used in arithmetic, rather > > than rely on test_bit() and friends to return this (though they probably > > should). > > iirc i looked at doing this as part of the folio work, and it ended up > increasing the size of the kernel. Did you run bloat-o-meter on the > result of doing this?
Hmmm. With my usual monolithic x86_64 kernel, it makes vmlinux text section 100 bytes larger (19392347 rather than 19392247). I can look into why.
David
| |