Messages in this thread | | | Date | Fri, 9 Apr 2021 12:46:17 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4/4] rtc:abx80x: Enable xt digital calibration |
| |
Hi!
> The XT digital calibration feature allows to improve the RTC accuracy, > using a Distributed Digital Calibration function. > See ch. 5.9.1 of AB08XX Series Ultra Low Power RTC IC User's Guide > https://abracon.com/realtimeclock/AB08XX-Application-Manual.pdf > > Signed-off-by: Kirill Kapranov <kirill.kapranov@compulab.co.il> > --- > drivers/rtc/rtc-abx80x.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 145 insertions(+)
> > +static const int xt_freq_nom = 32768000; //Nominal XT frequency 32 kHz in mHz
C-style comment?
is it 32 kHz or 32.768 kHz?
> +{ > + int retval; > + long Adj;
Adj -> adj.
> + > +static DEVICE_ATTR_WO(xt_frequency);
You are adding new user interface, you sould add documentation.
Best regards, Pavel
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] | |