Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [RFC PATCH 01/10] genirq: Add chip flag to denote automatic IRQ (un)masking | Date | Fri, 09 Apr 2021 11:34:07 +0100 |
| |
Hi Jonathan,
Thanks for taking a peek :)
On 09/04/21 10:17, Jonathan Cameron wrote: > On Thu, 8 Apr 2021 16:43:17 +0100 > Valentin Schneider <valentin.schneider@arm.com> wrote: >> diff --git a/include/linux/irq.h b/include/linux/irq.h >> index bee82809107c..580b1b6b1799 100644 >> --- a/include/linux/irq.h >> +++ b/include/linux/irq.h >> @@ -219,6 +219,8 @@ struct irq_data { >> * irq_chip::irq_set_affinity() when deactivated. >> * IRQD_IRQ_ENABLED_ON_SUSPEND - Interrupt is enabled on suspend by irq pm if >> * irqchip have flag IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND set. >> + * IRQD_IRQ_FLOW_MASKED - Interrupt is masked by ACK. Only EOI can >> + * clear this. > > Nitpick of the day : Seems text above is using tabs for white space blocks > whereas you have used spaces. Make it consistent. > It's not consistent in the file so I guess you could clean that up, or > just go with making it consistent in this block. >
I usually let my editor take the wheel when it comes to whitespace vs tabs, but it does look like it's not aligned with the rest here.
| |