Messages in this thread | | | Subject | Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log | From | Hui Tang <> | Date | Fri, 9 Apr 2021 17:30:41 +0800 |
| |
On 2021/4/9 15:33, Herbert Xu wrote: > On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote: >> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not >> necessary to do it here, so remove it. >> >> Signed-off-by: Hui Tang <tanghui20@huawei.com> >> >> v1 -> v2: >> - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero. >> --- >> drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Your patch description is misleading as the patch does moe than > just remove the redundant printk. Please rephrase so that it is > clear that the patch is in fact changing behaviour.
Okay, I will fix it in next version. >
| |