Messages in this thread | | | Date | Fri, 9 Apr 2021 11:22:26 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers |
| |
On Thu, Apr 08, 2021 at 11:23:03PM -0700, Andrew Morton wrote: > On Wed, 7 Apr 2021 11:46:37 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > > On Wed, Apr 7, 2021 at 11:17 AM Kees Cook <keescook@chromium.org> wrote: > > > > > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > > > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > > > Here is the attempt to start cleaning it up by splitting out panic and > > > > oops helpers. > > > > > > > > At the same time convert users in header and lib folder to use new header. > > > > Though for time being include new header back to kernel.h to avoid twisted > > > > indirected includes for existing users. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > I like it! Do you have a multi-arch CI to do allmodconfig builds to > > > double-check this? > > > > Unfortunately no, I rely on plenty of bots that are harvesting mailing lists. > > > > But I will appreciate it if somebody can run this through various build tests. > > > > um, did you try x86_64 allmodconfig? > > I'm up to > kernelh-split-out-panic-and-oops-helpers-fix-fix-fix-fix-fix-fix-fix.patch > and counting.
I will try on my side and will fix those, thanks!
> and.... drivers/leds/trigger/ledtrig-heartbeat.c as well. > > I'll drop it.
No problem, thanks for the report.
-- With Best Regards, Andy Shevchenko
| |