lkml.org 
[lkml]   [2021]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
From
Date
Hi Laibin

On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
> ---
> drivers/mmc/host/sdhci-st.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "top-mmc-delay");
> pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pdata->top_ioaddr)) {
> - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> + if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
> - }
>
> pltfm_host->clk = clk;
> pdata->icnclk = icnclk;
>

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice

\
 
 \ /
  Last update: 2021-04-09 09:43    [W:0.032 / U:22.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site