Messages in this thread | | | Date | Fri, 9 Apr 2021 17:19:41 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: deflate - Remove useless call "zlib_inflateEnd" |
| |
On Wed, Mar 31, 2021 at 11:34:57AM +0800, Jiapeng Chong wrote: > Fix the following whitescan warning: > > Calling "zlib_inflateEnd(&ctx->decomp_stream)" is only useful for its > return value, which is ignored. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > crypto/deflate.c | 1 - > 1 file changed, 1 deletion(-)
The function might not do anything today but the documentation clearly indicates that it could free any dynamically allocated data so it should stay.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |