lkml.org 
[lkml]   [2021]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check
From
Date
On 4/9/21 12:56 PM, David Laight wrote:
> From: Chris von Recklinghausen
>> Sent: 08 April 2021 11:46
>>
>> Suspend fails on a system in fips mode because md5 is used for the e820
>> integrity check and is not available. Use crc32 instead.
>>
>> Prior to this patch, MD5 is used only to create a digest to ensure integrity of
>> the region, no actual encryption is done. This patch set changes the integrity
>> check to use crc32 instead of md5 since crc32 is available in both FIPS and
>> non-FIPS modes.
>>
>> Note that the digest is only used as an integrity check. No actual encryption
>> is done.
> If crc32 is good enough, would a 1's compliment sum be good enough?
> It is likely to be faster to calculate and not need special
> functions be built into the kernel at all.


Eric Biggers <ebiggers@kernel.org> suggested using crc32_le() which is
in the library interface (lib/crc32.c) and will always be available
without any special ifdefs. That's what my next version will be based on.

Thanks,

Chris


>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>

\
 
 \ /
  Last update: 2021-04-09 21:29    [W:0.039 / U:1.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site