lkml.org 
[lkml]   [2021]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] dt-bindings: mfd: pm8008: Add IRQ listing
On Fri, Apr 09, 2021 at 10:55:19AM -0500, Bjorn Andersson wrote:
> On Thu 08 Apr 19:38 CDT 2021, Guru Das Srinagesh wrote:
>
> > Add a header file listing all of the IRQs that Qualcomm Technologies,
> > Inc. PM8008 supports. The constants defined in this file may be used in
> > the client device tree node to specify interrupts.
> >
> > Change-Id: I13fb096da54458f2882e8d853a3ad9c379e7d5a9
>
> Please remember to drop the Change-Id when posting to the mailing lists.
>
>
> We typically don't have defines for the IRQ numbers, but I don't mind.

But I do because then others will think it's a good idea.

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
> > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> > ---
> > include/dt-bindings/mfd/qcom-pm8008.h | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644 include/dt-bindings/mfd/qcom-pm8008.h
> >
> > diff --git a/include/dt-bindings/mfd/qcom-pm8008.h b/include/dt-bindings/mfd/qcom-pm8008.h
> > new file mode 100644
> > index 0000000..eca9448
> > --- /dev/null
> > +++ b/include/dt-bindings/mfd/qcom-pm8008.h
> > @@ -0,0 +1,19 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (c) 2021 The Linux Foundation. All rights reserved.
> > + */
> > +
> > +#ifndef __DT_BINDINGS_MFD_QCOM_PM8008_H
> > +#define __DT_BINDINGS_MFD_QCOM_PM8008_H
> > +
> > +/* PM8008 IRQ numbers */
> > +#define PM8008_IRQ_MISC_UVLO 0
> > +#define PM8008_IRQ_MISC_OVLO 1
> > +#define PM8008_IRQ_MISC_OTST2 2
> > +#define PM8008_IRQ_MISC_OTST3 3
> > +#define PM8008_IRQ_MISC_LDO_OCP 4
> > +#define PM8008_IRQ_TEMP_ALARM 5
> > +#define PM8008_IRQ_GPIO1 6
> > +#define PM8008_IRQ_GPIO2 7
> > +
> > +#endif
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >

\
 
 \ /
  Last update: 2021-04-09 20:56    [W:0.044 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site