Messages in this thread | | | Date | Fri, 9 Apr 2021 11:54:55 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible |
| |
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote: > From: Matteo Croce <mcroce@microsoft.com> > > use the new helper macro skb_for_each_frag() which allows to iterate > through all the SKB fragments. > > The patch was created with Coccinelle, this was the semantic patch:
Bunch of set but not used warnings here. Please make sure the code builds cleanly allmodconfig, W=1 C=1 before posting.
What pops to mind (although quite nit picky) is the question if the assembly changes much between driver which used to cache nr_frags and now always going skb_shinfo(skb)->nr_frags? It's a relatively common pattern.
| |