lkml.org 
[lkml]   [2021]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()
On Fri, 9 Apr 2021 at 08:11, Ye Weihua <yeweihua4@huawei.com> wrote:
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Weihua <yeweihua4@huawei.com>

Hi,

The same Lukasz' comment applies here as for Qinglang's patch from
November 2020 - resume also needs fix up.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-04-09 08:17    [W:0.026 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site