Messages in this thread | | | Date | Fri, 9 Apr 2021 15:35:55 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 03/17] bit_spinlock: Prepare for split_locks |
| |
On Fri, Apr 09, 2021 at 10:32:47AM -0400, Theodore Ts'o wrote: > On Fri, Apr 09, 2021 at 03:51:17AM +0100, Matthew Wilcox (Oracle) wrote: > > Make bit_spin_lock() and variants variadic to help with the transition. > > The split_lock parameter will become mandatory at the end of the series. > > Also add bit_spin_lock_nested() and bit_spin_unlock_assign() which will > > both be used by the rhashtable code later. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > This changes the function signature for bit_spin_lock(), if I'm > reading this correctly. Hence, this is going to break git > bisectability; was this patch series separated out for easy of review, > and you were planning on collapsing things into a single patch to > preserve bisectability?
It's perfectly bisectable.
Before: bit_spin_lock takes two arguments During: bit_spin_lock takes at least two arguments, ignores all but the first two After: bit_spin_lock takes three arguments
| |