Messages in this thread | | | Date | Thu, 8 Apr 2021 08:20:38 +0200 | From | Greg KH <> | Subject | Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support |
| |
On Wed, Apr 07, 2021 at 08:00:38PM +0000, Min Li wrote: > > > > Do you really meen "+" here? (sorry, have to ask.) > > > > I don't know. All of our Linux kernel code has GPL-2.0+ and I just blindly inherit it.
You should ask your managers :)
> > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > > You should not need this as it's a driver, so you should only use the > > dev_dbg() family of print message functions, no need for pr_*() calls. > > > I have one call to pr_err in rsmu_init > > pr_err("Unabled to register %s platform driver", DRIVER_NAME); >
My recommendation in another email shows that the line above is not needed...
thanks,
greg k-h
| |