Messages in this thread | | | Date | Thu, 8 Apr 2021 17:05:54 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces |
| |
On Thu, Apr 08, 2021 at 03:44:57PM +0200, Jessica Yu wrote: > +++ Stephen Boyd [30/03/21 20:05 -0700]:
...
> > +static void init_build_id(struct module *mod, const struct load_info *info) > > +{ > > + const Elf_Shdr *sechdr; > > + unsigned int i; > > + > > + for (i = 0; i < info->hdr->e_shnum; i++) { > > + sechdr = &info->sechdrs[i]; > > + if (!sect_empty(sechdr) && sechdr->sh_type == SHT_NOTE && > > + !build_id_parse_buf((void *)sechdr->sh_addr, mod->build_id, > > + sechdr->sh_size)) > > + break; > > + } > > +} > > Why not just look for the .note.gnu.build-id section instead of trying > to parse each note section? Doesn't it always contain the build id? At > least the ld man page seems to suggest this section name should be > consistent.
Interesting idea (in positive way!), I'm wondering what Clang does in such case.
-- With Best Regards, Andy Shevchenko
| |