Messages in this thread | | | From | Jinpu Wang <> | Date | Thu, 8 Apr 2021 07:21:06 +0200 | Subject | Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop |
| |
On Wed, Apr 7, 2021 at 7:18 PM Martin K. Petersen <martin.petersen@oracle.com> wrote: > > > Hi Colin! > > > The for-loop iterates with a u8 loop counter i and compares this with > > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > > There is a potential infinite loop if pm8001_ha->max_q_num is larger > > than the u8 loop counter. Fix this by making the loop counter the same > > type as pm8001_ha->max_q_num. > > No particular objections to the patch for future-proofing. However, as > far as I can tell max_q_num is capped at 64 (PM8001_MAX_MSIX_VEC). Exactly. > > -- > Martin K. Petersen Oracle Linux Engineering
| |