Messages in this thread | | | Subject | Re: [PATCH 1/2] powerpc: remove set but not used variable 'force_printk_to_btext' | From | "yukuai (C)" <> | Date | Thu, 8 Apr 2021 17:30:24 +0800 |
| |
On 2021/04/08 13:01, Christophe Leroy wrote: > > > Le 08/04/2021 à 03:18, Yu Kuai a écrit : >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' >> defined but not used. > > You don't get this error as it is now. > You will get this error only if you make it 'static', which is what you > did in your first patch based on the 'sparse' report. > > When removing a non static variable, you should explain that you can > remove it after you have verifier that it is nowhere used, neither in > that file nor in any other one.
Hi,
I do use 'git grep force_printk_to_btext' to confirm that 'force_printk_to_btext' is not used anywhere. Maybe it's better to metion it in commit message?
Thanks Yu Kuai > >> >> It is never used, and so can be removed. >> >> Signed-off-by: Yu Kuai <yukuai3@huawei.com> >> --- >> arch/powerpc/kernel/btext.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c >> index 803c2a45b22a..359d0f4ca532 100644 >> --- a/arch/powerpc/kernel/btext.c >> +++ b/arch/powerpc/kernel/btext.c >> @@ -46,7 +46,6 @@ unsigned long disp_BAT[2] __initdata = {0, 0}; >> static unsigned char vga_font[cmapsz]; >> int boot_text_mapped __force_data = 0; >> -int force_printk_to_btext = 0; >> extern void rmci_on(void); >> extern void rmci_off(void); >> > . >
| |