Messages in this thread | | | Date | Thu, 8 Apr 2021 11:01:07 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs |
| |
On Thu, Apr 08, 2021 at 11:52:40AM +0300, Jarkko Sakkinen wrote: > I think these attributes are quite useful information to have available so > I'd go actually doing sysfs attributes and create > Documentation/ABI/stable/sysfs-driver-sgx to document them.
testing/ This directory documents interfaces that are felt to be stable, as the main development of this interface has been completed.
This sounds better for a start. From Documentation/ABI/README.
> Given that they would go then to the sysfs directory of the driver, then > probably the legit names for the attributes ought to be: > > - nr_all_epc_pages > - nr_free_epc_pages > > What do you think?
Sounds ok to me.
> PS. One useful case that I forgot to mention is that I use these to give > idea what I gave EPC size in the BIOS. Now my EPC is set to 32 MB, and > these report 20 MB of EPC pages. It's because other metadata (e.g. EPCM > containing page attributes) is also stored in this area.
Just remember to put yourself in the user's shoes and think whether they make sense to her/him.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |