lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] staging: rtl8188eu: remove unused macros
On Wed, Apr 07, 2021 at 07:05:22PM +0200, Martin Kaiser wrote:
> usb_ops_linux.h contains a couple of macros to make functions usable as
> urb completion callbacks. Most of them are unused and can be removed.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/rtl8188eu/include/usb_ops_linux.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> index 4e0e48cb5c8e..1a0b38de5027 100644
> --- a/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> +++ b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> @@ -23,18 +23,10 @@
> #define USB_HIGH_SPEED_BULK_SIZE 512
> #define USB_FULL_SPEED_BULK_SIZE 64
>
> -#define _usbctrl_vendorreq_async_callback(urb, regs) \
> - _usbctrl_vendorreq_async_callback(urb)
> -#define usb_bulkout_zero_complete(purb, regs) \
> - usb_bulkout_zero_complete(purb)
> -#define usb_write_mem_complete(purb, regs) \
> - usb_write_mem_complete(purb)
> #define usb_write_port_complete(purb, regs) \
> usb_write_port_complete(purb)
> #define usb_read_port_complete(purb, regs) \
> usb_read_port_complete(purb)
> -#define usb_read_interrupt_complete(purb, regs) \
> - usb_read_interrupt_complete(purb)

Wow, that's there for a really old kernel version and should not be
needed anymore at all. I'll take this, but please remove the other ones
here, they are not necessary.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-04-08 09:26    [W:0.158 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site