Messages in this thread | | | Subject | Re: [PATCH v3] swiotlb: Make SWIOTLB_NO_FORCE perform no allocation | From | Florian Fainelli <> | Date | Thu, 8 Apr 2021 20:13:07 -0700 |
| |
On 3/24/2021 1:42 AM, Christoph Hellwig wrote: > On Mon, Mar 22, 2021 at 06:53:49PM -0700, Florian Fainelli wrote: >> When SWIOTLB_NO_FORCE is used, there should really be no allocations of >> default_nslabs to occur since we are not going to use those slabs. If a >> platform was somehow setting swiotlb_no_force and a later call to >> swiotlb_init() was to be made we would still be proceeding with >> allocating the default SWIOTLB size (64MB), whereas if swiotlb=noforce >> was set on the kernel command line we would have only allocated 2KB. >> >> This would be inconsistent and the point of initializing default_nslabs >> to 1, was intended to allocate the minimum amount of memory possible, so >> simply remove that minimal allocation period. >> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> >
Thanks! Konrad, can you apply this patch to your for-linus-5.13 branch if you are also happy with it? -- Florian
| |