Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 9 Apr 2021 05:09:10 +0200 | Subject | Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static |
| |
On Fri, Apr 9, 2021 at 2:20 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Quite a few other functions are declared in a header, but I don't see > any existing callers in tree. I wonder if the maintainer could > consider cleaning these up so that we don't retain them in binaries > without dead code elimination enabled, or if there's a need to keep > this code in line with an external upstream codebase?
Yeah, the equivalent cleanup was done upstream by Nick in 2018 [1], but there has been no major update to lib/zstd since 2017.
Thus a cleanup would actually make it closer to upstream, which is the best case scenario :)
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
[1] https://github.com/facebook/zstd/commit/f2d6db45cd28457fa08467416e8535985f062859
Cheers, Miguel
| |