lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema
Date
Hi Rob,

thanks for your feedback.

> From: Rob Herring <robh+dt@kernel.org>
> Sent: 07 April 2021 19:27
> Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif:
> Convert to json-schema
>
> On Thu, Jan 14, 2021 at 7:02 AM Geert Uytterhoeven <geert@linux-m68k.org>
> wrote:
> >
> > Hi Fabrizio, Rob,
> >
> > On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com> wrote:
> > > Convert the Renesas DRIF bindings to DT schema and update
> > > MAINTAINERS accordingly.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your patch!
> >
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> >
> > > + clock-names:
> > > + maxItems: 1
> > > + items:
> > > + - const: fck
> >
> > With latest dt-schema, "make dt_binding_check" complains:
> >
> > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > properties:clock-names:maxItems: False schema does not allow 1
> > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > ignoring, error in schema: properties: clock-names: maxItems
>
> Seems this just got applied, and now this error is in linux-next.

I'll send a patch to fix the problem shortly.

Thanks,
Fab

>
> >
> > Using
> >
> > clock-names:
> > const: fck
> >
> > Fixes that.
> >
> > However, I'm wondering why I do not get a complaint about the similar
> > clock/clock-names in
> > Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml.
> > Because they're part of an else branch?
>
> Probably. if/then/else schemas have fewer checks as they can be
> incomplete (only additional constraints on the top-level schema).
>
> Rob
\
 
 \ /
  Last update: 2021-04-08 22:24    [W:0.088 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site