Messages in this thread | | | Subject | Re: [PATCH] clk: fix for_each_child.cocci warnings | From | Stephen Boyd <> | Date | Wed, 07 Apr 2021 17:31:13 -0700 |
| |
Quoting Julia Lawall (2021-04-07 12:02:32) > From: kernel test robot <lkp@intel.com> > > For_each_child_of_node should have of_node_put() before goto. > > Generated by: scripts/coccinelle/iterators/for_each_child.cocci > > CC: Liam Beguin <lvb@xiphos.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr> > ---
Is this a fix for a patch on the list?
> > url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408 > base: f40ddce88593482919761f74910f42f4b84c004b > :::::: branch date: 9 hours ago > :::::: commit date: 9 hours ago > > clk-lmk04832.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/clk/clk-lmk04832.c > +++ b/drivers/clk/clk-lmk04832.c > @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev > if (ret) { > dev_err(lmk->dev, "missing reg property in child: %s\n", > child->full_name); > + of_node_put(child); > goto err_disable_oscin; > } >
| |