lkml.org 
[lkml]   [2021]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests/resctrl: Change a few printed messages
From
Date
On 4/7/21 11:12 AM, Fenghua Yu wrote:
> Hi, Shuah,
>
> On Wed, Apr 07, 2021 at 08:33:23AM -0600, Shuah Khan wrote:
>> On 4/5/21 6:52 PM, Fenghua Yu wrote:
>>> - ksft_print_msg("%s cache miss rate within %d%%\n",
>>> - ret ? "Fail:" : "Pass:", max_diff_percent);
>>> + ksft_print_msg("Check cache miss rate within %d%%\n", max_diff_percent);
>>
>> You need %s and pass in the ret ? "Fail:" : "Pass:" result for the
>> message to read correctly.
>
> Should I keep the ":" after "Pass"/"Fail"?
>

Yes please.

>>
>> I am seeing:
>>
>> # Check kernel support for resctrl filesystem
>>
>> It should say the following:
>>
>> # Fail Check kernel support for resctrl filesystem
>
> i.e. should the printed messages be like the following?
> # Fail: Check kernel support for resctrl filesystem
> or
> # Pass: Check kernel support for resctrl filesystem
>

This looks good.

thanks,
-- Shuah


\
 
 \ /
  Last update: 2021-04-07 20:16    [W:0.068 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site