Messages in this thread | | | Subject | Re: [PATCH] memory: atmel-sdramc: check of_device_get_match_data() return value | From | Krzysztof Kozlowski <> | Date | Wed, 7 Apr 2021 18:55:27 +0200 |
| |
On 07/04/2021 18:19, Alexandre Belloni wrote: > Hi, > > On 07/04/2021 17:44:47+0200, Krzysztof Kozlowski wrote: >> If the driver is probed, the of_device_get_match_data() should not >> return NULL, however for sanity check its return value. >> > > As you say, there is no way this will ever be the case, I don't see the > point of checking the return value, this adds 12 bytes for nothing... > > Maybe coverity should be fixed as there are many drivers making the same > (true) assumption and I don't think this is worth the churn.
There are also several drivers having this check. To me an explicit NULL check is better and more readable than non-obvious assumption that the of_device_id table contains data for each entry and there is no other bind method (like for OF+I2C drivers). Even if the case is not real, this is nice, simple and explicit code.
Best regards, Krzysztof
| |