Messages in this thread | | | Date | Tue, 6 Apr 2021 18:44:00 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h |
| |
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected > by checkpatch.pl. Spaces are preferred to improve readibility. > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > --- > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h > index 59e8c68cdc20..719e19420a3b 100644 > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h > @@ -15,7 +15,7 @@ > #define BT_INFO_8723B_1ANT_B_CONNECTION BIT0 > > #define BT_INFO_8723B_1ANT_A2DP_BASIC_RATE(_BT_INFO_EXT_) \ > - (((_BT_INFO_EXT_&BIT0)) ? true : false) > + (((_BT_INFO_EXT_ & BIT0)) ? true : false)
There seem to be a lot of parentheses in this code (( )). Maybe you can make a series and fix that problem too.
julia
> > #define BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT 2 > > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210406164001.13646-1-fmdefrancesco%40gmail.com. >
| |