Messages in this thread | | | Subject | Re: [PATCH] clk: socfpga: arria10: Fix memory leak of socfpga_clk on error return | From | Dinh Nguyen <> | Date | Tue, 6 Apr 2021 13:13:56 -0500 |
| |
On 4/6/21 12:01 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There is an error return path that is not kfree'ing socfpga_clk leading > to a memory leak. Fix this by adding in the missing kfree call. > > Addresses-Coverity: ("Resource leak") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/clk/socfpga/clk-gate-a10.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/socfpga/clk-gate-a10.c b/drivers/clk/socfpga/clk-gate-a10.c > index f5cba8298712..738c53391e39 100644 > --- a/drivers/clk/socfpga/clk-gate-a10.c > +++ b/drivers/clk/socfpga/clk-gate-a10.c > @@ -146,6 +146,7 @@ static void __init __socfpga_gate_init(struct device_node *node, > if (IS_ERR(socfpga_clk->sys_mgr_base_addr)) { > pr_err("%s: failed to find altr,sys-mgr regmap!\n", > __func__); > + kfree(socfpga_clk); > return; > } > } >
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
| |