lkml.org 
[lkml]   [2021]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 9/9] w1: ds2438: support for writing to offset register
On Mon, Apr 05, 2021 at 01:04:59PM +0200, Greg KH wrote:
> On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote:
> > Added a sysfs entry to support writing to the offset register on page1.
> > This register is used to calibrate the chip canceling offset errors in the
> > current ADC. This means that, over time, reading the IAD register will not
> > return the correct current measurement, it will have an offset. Writing to
> > the offset register if the two's complement of the current register while
> > passing zero current to the load will calibrate the measurements. This
> > change was tested on real hardware and it was able to calibrate the chip
> > correctly.
> >
> > Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
> > ---
> > Documentation/w1/slaves/w1_ds2438.rst | 11 +++++-
> > drivers/w1/slaves/w1_ds2438.c | 49 +++++++++++++++++++++++++++
> > 2 files changed, 59 insertions(+), 1 deletion(-)
>
> In this, and the previous patch, you added new sysfs files, but no
> update to Documentation/ABI/ for them. Please fix that up.
>
> thanks,
>
> greg k-h

Hello! I'm sorry about some errors, this is my first patch and I'm not sure about some things in the documentation. I really appreciate the responses and guidance.
The file I need to add to Documentation/ABI/ is going to be in testing or stable? And the file I need to create can be called, for instance, sysfs-driver-w1_ds2438?

Thanks!

\
 
 \ /
  Last update: 2021-04-05 14:43    [W:1.023 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site