Messages in this thread | | | From | Muchun Song <> | Date | Sat, 3 Apr 2021 13:47:05 +0800 | Subject | Re: [External] [PATCH 2/3] mm: Charge active memcg when no mm is set |
| |
On Sat, Apr 3, 2021 at 3:17 AM Dan Schatzberg <schatzberg.dan@gmail.com> wrote: > > set_active_memcg() worked for kernel allocations but was silently > ignored for user pages. > > This patch establishes a precedence order for who gets charged: > > 1. If there is a memcg associated with the page already, that memcg is > charged. This happens during swapin. > > 2. If an explicit mm is passed, mm->memcg is charged. This happens > during page faults, which can be triggered in remote VMs (eg gup). > > 3. Otherwise consult the current process context. If there is an > active_memcg, use that. Otherwise, current->mm->memcg. > > Previously, if a NULL mm was passed to mem_cgroup_charge (case 3) it > would always charge the root cgroup. Now it looks up the active_memcg > first (falling back to charging the root cgroup if not set). > > Signed-off-by: Dan Schatzberg <schatzberg.dan@gmail.com> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Acked-by: Tejun Heo <tj@kernel.org> > Acked-by: Chris Down <chris@chrisdown.name> > Reviewed-by: Shakeel Butt <shakeelb@google.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
| |