lkml.org 
[lkml]   [2021]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v1 2/9] net: dsa: tag_ar9331: detect IGMP and MLD packets
    > @@ -31,6 +96,13 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb,
    > __le16 *phdr;
    > u16 hdr;
    >
    > + if (dp->stp_state == BR_STATE_BLOCKING) {
    > + /* TODO: should we reflect it in the stats? */
    > + netdev_warn_once(dev, "%s:%i dropping blocking packet\n",
    > + __func__, __LINE__);
    > + return NULL;
    > + }
    > +
    > phdr = skb_push(skb, AR9331_HDR_LEN);
    >
    > hdr = FIELD_PREP(AR9331_HDR_VERSION_MASK, AR9331_HDR_VERSION);

    Hi Oleksij

    This change does not seem to fit with what this patch is doing.

    I also think it is wrong. You still need BPDU to pass through a
    blocked port, otherwise spanning tree protocol will be unstable.

    Andrew

    \
     
     \ /
      Last update: 2021-04-03 16:51    [W:2.418 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site