Messages in this thread | | | From | "Song Bao Hua (Barry Song)" <> | Subject | RE: [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within a die | Date | Fri, 30 Apr 2021 03:46:04 +0000 |
| |
> -----Original Message----- > From: Andrew Jones [mailto:drjones@redhat.com] > Sent: Wednesday, April 28, 2021 9:48 PM > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com> > Cc: aubrey.li@linux.intel.com; bp@alien8.de; bsegall@google.com; > catalin.marinas@arm.com; dietmar.eggemann@arm.com; > gregkh@linuxfoundation.org; guodong.xu@linaro.org; hpa@zytor.com; Jonathan > Cameron <jonathan.cameron@huawei.com>; juri.lelli@redhat.com; > lenb@kernel.org; Liguozhu (Kenneth) <liguozhu@hisilicon.com>; > linux-acpi@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linuxarm@openeuler.org; mark.rutland@arm.com; > mgorman@suse.de; mingo@redhat.com; msys.mizuma@gmail.com; > peterz@infradead.org; Zengtao (B) <prime.zeng@hisilicon.com>; > rjw@rjwysocki.net; rostedt@goodmis.org; sudeep.holla@arm.com; > tglx@linutronix.de; tim.c.chen@linux.intel.com; valentin.schneider@arm.com; > vincent.guittot@linaro.org; will@kernel.org; x86@kernel.org; xuwei (O) > <xuwei5@huawei.com>; yangyicong <yangyicong@huawei.com> > Subject: Re: [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within > a die > > On 20/04/2021 12:18, Barry Song wrote: > ... > > Currently the ID provided is the offset of the Processor > > Hierarchy Nodes Structure within PPTT. Whilst this is unique > > it is not terribly elegant so alternative suggestions welcome. > > > > The ACPI table offsets are consistent with how other topology IDs are > generated. I once tried to make them a little more human friendly with > [1], but it was nacked. > > [1] https://lore.kernel.org/lkml/20180629132934.GA16282@e107155-lin/t/ >
Ideally, we are going to check if cluster node has a valid UID, if yes, read this ID; otherwise, fall back to use offset.
Will move to that way in next version.
> Thanks, > drew
Thanks Barry
| |