Messages in this thread Patch in this message | | | From | Ben Boeckel <> | Subject | [PATCH v2 1/1] trusted-keys: match tpm_get_ops on all return paths | Date | Thu, 29 Apr 2021 15:21:56 -0400 |
| |
From: Ben Boeckel <mathstuf@gmail.com>
The `tpm_get_ops` call at the beginning of the function is not paired with a `tpm_put_ops` on this return path.
Fixes: f2219745250f ("security: keys: trusted: use ASN.1 TPM2 key format for the blobs") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ben Boeckel <mathstuf@gmail.com> --- security/keys/trusted-keys/trusted_tpm2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trusted-keys/trusted_tpm2.c index 617fabd4d913..0165da386289 100644 --- a/security/keys/trusted-keys/trusted_tpm2.c +++ b/security/keys/trusted-keys/trusted_tpm2.c @@ -336,9 +336,9 @@ int tpm2_seal_trusted(struct tpm_chip *chip, rc = -EPERM; } if (blob_len < 0) - return blob_len; - - payload->blob_len = blob_len; + rc = blob_len; + else + payload->blob_len = blob_len; tpm_put_ops(chip); return rc; -- 2.30.2
| |