Messages in this thread | | | Date | Thu, 29 Apr 2021 19:49:21 +0200 | From | Jonathan Neuschäfer <> | Subject | Re: [PATCH] powerpc/32: Fix boot failure with CONFIG_STACKPROTECTOR |
| |
On Thu, Apr 29, 2021 at 04:52:09PM +0000, Christophe Leroy wrote: > Commit 7c95d8893fb5 ("powerpc: Change calling convention for > create_branch() et. al.") complexified the frame of function > do_feature_fixups(), leading to GCC setting up a stack > guard when CONFIG_STACKPROTECTOR is selected. > > The problem is that do_feature_fixups() is called very early > while 'current' in r2 is not set up yet and the code is still > not at the final address used at link time. > > So, like other instrumentation, stack protection needs to be > deactivated for feature-fixups.c and code-patching.c > > Reported-by: Jonathan Neuschaefer <j.neuschaefer@gmx.net> > Fixes: 7c95d8893fb5 ("powerpc: Change calling convention for create_branch() et. al.") > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > ---
Thank you for looking into this issue. This patch does indeed fix my issue.
Tested-by: Jonathan Neuschaefer <j.neuschaefer@gmx.net>
Thanks again, Jonathan [unhandled content-type:application/pgp-signature] | |